Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dynamics aspect for collision shape in sdf parser #1386

Merged
merged 2 commits into from
Aug 10, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 10, 2019


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Aug 10, 2019
@jslee02 jslee02 marked this pull request as ready for review August 10, 2019 05:53
@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #1386 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1386      +/-   ##
==========================================
- Coverage      57%   56.98%   -0.03%     
==========================================
  Files         366      366              
  Lines       27415    27416       +1     
==========================================
- Hits        15628    15622       -6     
- Misses      11787    11794       +7
Impacted Files Coverage Δ
dart/utils/sdf/SdfParser.cpp 66.17% <100%> (+0.06%) ⬆️
dart/constraint/ContactConstraint.cpp 71.97% <0%> (-2.95%) ⬇️
dart/dynamics/Skeleton.cpp 66.22% <0%> (+0.16%) ⬆️

@jslee02 jslee02 merged commit 6b889db into master Aug 10, 2019
@jslee02 jslee02 deleted the sdf_parser_dynamics_aspect branch August 10, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant