Reset internal force of point mass before every simulation step #1372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The soft body simulation behaves unexpectedly when the simulation option is
resetCommand = false
. The root cause was that the internal forces of point masses, which are used for soft body simulation, are not reset to zero in every simulation step. In the rigid body case, this issues doesn't happen because the internal forces are set to the control command. Soft body, however, doesn't have control command API so it keeps the previous value, and this leads to the unexpected behavior.This PR fixes the issue by always setting the internal forces of point mass to zero regardless of the
resetCommand
option.Resolves #1370
Before creating a pull request
clang-format
Before merging a pull request
CHANGELOG.md