Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dartpy] Add grid visual #1318

Merged
merged 3 commits into from
May 17, 2019
Merged

[dartpy] Add grid visual #1318

merged 3 commits into from
May 17, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 17, 2019

image


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change (N/A)

@jslee02 jslee02 added this to the DART 6.9.0 milestone May 17, 2019
@jslee02 jslee02 marked this pull request as ready for review May 17, 2019 01:59
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a253a58). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1318   +/-   ##
=========================================
  Coverage          ?   57.12%           
=========================================
  Files             ?      366           
  Lines             ?    27050           
  Branches          ?        0           
=========================================
  Hits              ?    15452           
  Misses            ?    11598           
  Partials          ?        0

@jslee02 jslee02 merged commit 4286ab7 into master May 17, 2019
@jslee02 jslee02 deleted the dartpy/grid branch May 17, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant