Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add safeguard for accessing Assimp color #1313

Merged
merged 2 commits into from
May 11, 2019
Merged

Add safeguard for accessing Assimp color #1313

merged 2 commits into from
May 11, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 11, 2019 •
edited
Loading

Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.9.0 milestone May 11, 2019
@jslee02 jslee02 changed the title Add sanity check for accessing Assimp color Add safeguard for accessing Assimp color May 11, 2019
@jslee02 jslee02 marked this pull request as ready for review May 11, 2019 02:41
@codecov
Copy link

codecov bot commented May 11, 2019 •
edited
Loading

Codecov Report

Merging #1313 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1313      +/-   ##
==========================================
- Coverage   57.18%   57.18%   -0.01%     
==========================================
  Files         366      366              
  Lines       27023    27025       +2     
==========================================
  Hits        15454    15454              
- Misses      11569    11571       +2
Impacted Files Coverage Δ
dart/dynamics/MeshShape.cpp 64.56% <0%> (-1.04%) ⬇️

@jslee02 jslee02 merged commit 5f32bf1 into master May 11, 2019
@jslee02 jslee02 deleted the mesh_alpha branch May 11, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jslee02