Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsound null safety options #2427

Closed
elliette opened this issue May 9, 2024 · 2 comments
Closed

Remove unsound null safety options #2427

elliette opened this issue May 9, 2024 · 2 comments
Assignees
Labels
good first issue A good starting issue for contributors (issues with this label will appear in /contribute) P2 A bug or feature request we're likely to work on package:dwds triaged

Comments

@elliette
Copy link
Contributor

elliette commented May 9, 2024

After #2426, which removed all the unsound null-safety tests, we should also remove everywhere where we allow unsound null safety to be specified.

For example:

/// True if the module corresponding to this metadata was compiled with sound
/// null safety enabled.
final bool soundNullSafety;

@bkonyi bkonyi added P2 A bug or feature request we're likely to work on triaged good first issue A good starting issue for contributors (issues with this label will appear in /contribute) labels Jul 31, 2024
@jyameo
Copy link
Contributor

jyameo commented Oct 7, 2024

@bkonyi @elliette, just to clarify regarding this bug: do we want to completely remove all references to soundNullSafety, or should we enforce that its value is always true but retain the soundNullSafety variables for backward compatibility and to avoid potential regressions?

@bkonyi
Copy link
Collaborator

bkonyi commented Oct 7, 2024

I think we can remove everything except the actual flag from the argument parser. We should hide the flag and mark it as deprecated just to make sure we're not breaking anyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good starting issue for contributors (issues with this label will appear in /contribute) P2 A bug or feature request we're likely to work on package:dwds triaged
Projects
None yet
Development

No branches or pull requests

3 participants