Skip to content

Commit

Permalink
Add --use-mock-keychain to Chrome args (dart-archive/browser_launcher#63
Browse files Browse the repository at this point in the history
)

Bug: dart-lang/sdk#56519

Rolling the Chrome version in Dart CI to 128.0.6613.36
results in a system dialog requesting Chrome to use
the keychain in MacOS. This then results in timeouts due
to it being blocking. Instead, use a mock keychain.
  • Loading branch information
srujzs authored Aug 22, 2024
1 parent 8ed7db4 commit 2c690eb
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkgs/browser_launcher/lib/src/chrome.dart
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,10 @@ class Chrome {
'--disable-default-apps',
'--disable-translate',
'--start-maximized',
// When running on MacOS, Chrome may open system dialogs requesting
// credentials. This uses a mock keychain to avoid that dialog from
// blocking.
'--use-mock-keychain',
];
if (headless) {
args.add('--headless');
Expand Down

0 comments on commit 2c690eb

Please sign in to comment.