Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit spans with reasonable ends #3

Open
nex3 opened this issue Apr 29, 2015 · 0 comments
Open

Emit spans with reasonable ends #3

nex3 opened this issue Apr 29, 2015 · 0 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@nex3
Copy link
Member

nex3 commented Apr 29, 2015

Currently (unless the user passes in SourceFiles) the spans emitted by this package don't have useful end locations. Non-identifier spans are always point locations, although typically a source map entry is considered to continue until the next entry rather than being a single point. Identifier spans are even worse: their text fields are used to contain the identifier, which is often (usually) not actual text from the source file, which is what the field is for.

Issue dart-lang/source_span#3 will allow these spans to have the correct end position set without necessarily having access to the text of the span.

@nex3 nex3 added the type-enhancement A request for a change that isn't a bug label Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

1 participant