Json codable no type assumption in custom fromJson #59581
Conversation
cedvdb
changed the title
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/396629 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
|
https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request. |
3 similar comments
|
https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request. |
cedvdb
force-pushed
the
json_codable_no_map_assumption
branch
from
cc49d86
to
ba39aa4
Compare
|
https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request. |
3 similar comments
|
https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request. |
cedvdb
changed the title
|
https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request. |
cedvdb
changed the title
|
https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request. |
|
It seems there is already a PR for this here : #56665 |
This allows an user defined class to have a
fromJsonmethod with a parameter that is not aMap. Before this change the@JsonCodablemacro would check if a field has a fromJson constructor and assume that the parameter type was aMap. This PR uses the type of the parameter instead.Note: I have this weird behavior where I can only run the tests with the macros enabled once per branch, so I have to switch branches and run the tests on another.