Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAP] Use Service ID zones where beneficial #56794

Open
derekxu16 opened this issue Sep 26, 2024 · 3 comments
Open

[DAP] Use Service ID zones where beneficial #56794

derekxu16 opened this issue Sep 26, 2024 · 3 comments
Assignees
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. dds-dap DDS issues related to the Debug Adapter Protocol (DAP) implementation

Comments

@derekxu16
Copy link
Member

The APIs for managing Service ID zones have been released in package:vm_service 14.3.0. These APIs can be used to free object IDs when they are no longer needed, to ensure that objects associated with those IDs are not retained for longer than necessary.

@derekxu16 derekxu16 added area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. dds-dap DDS issues related to the Debug Adapter Protocol (DAP) implementation labels Sep 26, 2024
@a-siva
Copy link
Contributor

a-siva commented Oct 10, 2024

@DanTup now that this functionality has landed in vm service what is the possibility of wiring this up in DAP

@DanTup
Copy link
Collaborator

DanTup commented Oct 10, 2024

I'm hoping to look at this soon, I think it should be fairly straight-forward. The DAP spec says that variableReferences (which roughly map to the InstanceRefs we get from the VM) expire when execution resumes, so it should be fairly simple to manage the zone lifetimes around that.

@DanTup
Copy link
Collaborator

DanTup commented Oct 14, 2024

I've a change in progress for this, but I want to do some additional manual testing with Dart+Flutter. I have a slight concern about race conditions (eg. we decide to invalidate a zone, but at the same time we start processing some event like a debugger pause where we might evaluate breakpoint conditions) and the tests don't tend to generate the same level of traffic as a real app.

(If someone is able to trigger the trybots in the meantime though, that would be appreciated!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. dds-dap DDS issues related to the Debug Adapter Protocol (DAP) implementation
Projects
None yet
Development

No branches or pull requests

3 participants