-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failures on [DEPS] Update chrome_tag to latest beta (128.0.6613.36) #56519
Comments
//cc @fishythefish |
Better logs here: https://dart-ci.appspot.com/log/any/unittest-asserts-release-mac-arm64/14137/pkg/dds/test/devtools_server/remote_control_test It looks like this test is flaky already on all configurations. Perhaps this pushed it over the timeout threshold consistently on that configuration? |
FWIW, the bot just turned red for two runs and then went back to green:
https://screenshot.googleplex.com/6tzFoG88sL5UYA6
…On Tue, Aug 20, 2024 at 9:37 AM Srujan Gaddam ***@***.***> wrote:
Better logs here:
https://dart-ci.appspot.com/log/any/unittest-asserts-release-mac-arm64/14137/pkg/dds/test/devtools_server/remote_control_test
It looks like this test is flaky already on all configurations. Perhaps
this pushed it over the timeout threshold consistently on that
configuration?
—
Reply to this email directly, view it on GitHub
<#56519 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABNVPB3KGGCJ67FWKGH5XTZSNWGJAVCNFSM6AAAAABMYYENB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJZGI4DSMJTGI>
.
You are receiving this because you were mentioned.Message ID:
<dart-lang/sdk/issues/56519/2299289132 ***@***.***>
|
It went back to green I presume because I approved the failure after filing this issue. |
Ah, I missed that. |
It looks like the chrome_tag update also led to some timeouts with the expression compiler tests: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8739133313427483313/+/u/test_results/new_test_failures__logs_. I'll go ahead and revert this for now, but we should figure out what the issue is before the next stable. |
This reverts commit 30a720b. Reason for revert: Timeouts on a dds test and expression compiler tests when running against a mac. #56519 Original change's description: > [DEPS] Update chrome_tag to latest beta (128.0.6613.36) > > Change-Id: Ib1ba532046aea26daf47b3ad51611f347e7334b8 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381302 > Commit-Queue: Sigmund Cherem <[email protected]> > Reviewed-by: Sigmund Cherem <[email protected]> > Auto-Submit: Mayank Patke <[email protected]> Change-Id: Ie76f277fa05450d71dfb3f7abeefd0f6e6d87b9d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381387 Commit-Queue: Mayank Patke <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Mayank Patke <[email protected]>
Reverted in https://dart-review.googlesource.com/c/sdk/+/381387. |
Bug: dart-lang/sdk#56519 Rolling the Chrome version in Dart CI to 128.0.6613.36 results in a system dialog requesting Chrome to use the keychain in MacOS. This then results in timeouts due to it being blocking. Instead, use a mock keychain.
Bug: dart-lang/sdk#56519 Rolling the Chrome version in Dart CI to 128.0.6613.36 results in a system dialog requesting Chrome to use the keychain in MacOS. This then results in timeouts due to it being blocking. Instead, use a mock keychain.
…ain flag to dds With this roll, Chrome now triggers a dialog on MacOS requesting credentials. This results in timeouts for pkg/dds/test/devtools_server/remote_control_test. To avoid user input, we use a mock keychain instead. The same change has gone into browser_launcher_rev, and so we include that commit here. Bug: #56519 Change-Id: I0e0733b658eb09b0775178e617e5ceb42e184ec4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381705 Commit-Queue: Srujan Gaddam <[email protected]> Reviewed-by: Ben Konyi <[email protected]> Reviewed-by: Sigmund Cherem <[email protected]>
This has been re-rolled with some changes to how we start up Chrome, and should avoid the aforementioned timeouts. |
) Bug: dart-lang/sdk#56519 Rolling the Chrome version in Dart CI to 128.0.6613.36 results in a system dialog requesting Chrome to use the keychain in MacOS. This then results in timeouts due to it being blocking. Instead, use a mock keychain.
There are new test failures on [DEPS] Update chrome_tag to latest beta (128.0.6613.36).
The tests
are failing on configurations
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8739137491030815569/+/u/test_results/new_test_failures__logs_
The text was updated successfully, but these errors were encountered: