Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should tags on beta/stable cherry-picks be visible on the commit in github? #52999

Closed
sigmundch opened this issue Jul 20, 2023 · 2 comments
Closed
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.

Comments

@sigmundch
Copy link
Member

Not sure if this is possible to do or if this is a github issue directly. In a recent discussion in #52869 (comment) we noticed that a commit was not visibly marked as part of a release in the github commit. In particular, take for example the most recent beta release here: https://github.com/dart-lang/sdk/commits/3.1.0-262.2.beta

You can find the cherry-pick 1b6421a which indicates it landed in the beta branch, but it doesn't show the git tag 3.1.0-262.2.beta. Compare that to a commit from the main branch that didn't get cherry-picked, like: 63b567a, where the tag is present in the UI.

cc @athomas @itsjustkevin @nshahan

@sigmundch sigmundch added the area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. label Jul 20, 2023
@athomas
Copy link
Member

athomas commented Jul 21, 2023

Looks like a GH UI issue, because in a local checkout the tag is listed for 6179222

$ git tag --contains 617922293bd00069307a417b621885e72d3b3e71
3.1.0-262.2.beta

But 3.1.0-262.2.beta is known to GH. So they've likely decided to only show tags that are reachable from main for some reason.

https://github.com/refined-github/refined-github might be another workaround.

Looking at https://dart.googlesource.com/sdk/+log/beta is also a good way to see this for recent commits at a glance.

I'm going to close this, because I don't see a good way for us to do this. It's more of a GH feature request.

@athomas athomas closed this as completed Jul 21, 2023
@sigmundch
Copy link
Member Author

Makes sense. Thanks so much for digging into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
None yet
Development

No branches or pull requests

2 participants