Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Please cherry pick change e4942db83e2ad147de8710c0c96629f676fc91e3 (Avoid speculative conversion in ffi Pointer.asTypedList) #48301

Closed
a-siva opened this issue Feb 4, 2022 · 5 comments
Closed

[CP] Please cherry pick change e4942db83e2ad147de8710c0c96629f676fc91e3 (Avoid speculative conversion in ffi Pointer.asTypedList) #48301

a-siva opened this issue Feb 4, 2022 · 5 comments
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). cherry-pick-approved Label for approved cherrypick request merge-to-beta merge-to-stable

Comments

@a-siva
Copy link
Contributor

a-siva commented Feb 4, 2022

commit(s) to merge: e4942db

merge instructions: clean merge

What is the issue: Flutter AOT precompiler crash using isar package

What is the fix: This change fixes the type incompatibility by loading value with LoadUntagged and then converting it with ConvertUntaggedToUnboxed(kUnboxedIntPtr)

Why cherrypick: The issue was reported by Flutter user and it manifests as a crash in the AOT compiler when building a flutter app

Risk: low (has rolled into top of tree Flutter without any issues).

Link to original issue(s): flutter/flutter#97301

/cc @mit-mit @whesse @athomas @vsmenon @devoncarew
@a-siva a-siva added merge-to-stable cherry-pick-review Issue that need cherry pick triage to approve labels Feb 4, 2022
@a-siva
Copy link
Contributor Author

a-siva commented Feb 4, 2022

//cc @alexmarkov

@kevmoo kevmoo added the area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). label Feb 4, 2022
@devoncarew devoncarew added the cherry-pick-approved Label for approved cherrypick request label Feb 5, 2022
@devoncarew
Copy link
Member

Marking as cherry pick approved

@athomas athomas added merge-to-beta and removed cherry-pick-review Issue that need cherry pick triage to approve labels Feb 7, 2022
@athomas
Copy link
Member

athomas commented Feb 7, 2022 •
edited
Loading

This needs to go into both beta 2.17 and stable 2.16.1.

@athomas
Copy link
Member

athomas commented Feb 8, 2022

Merged to stable in 0180af2 (2.16.1).

Keeping the issue open until we've merged to beta.

@athomas
Copy link
Member

athomas commented Feb 14, 2022

Merged to beta in fa166c2 (2.17.0-69.2).

@athomas athomas closed this as completed Feb 14, 2022
@felangel felangel mentioned this issue May 6, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). cherry-pick-approved Label for approved cherrypick request merge-to-beta merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @devoncarew @a-siva @athomas