Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP][stable channel] Fix OOM VM test (transferable_throws_oom_test crashing after upgrade from Ubuntu 16 -> 18) #46300

Closed
a-siva opened this issue Jun 8, 2021 · 2 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve

Comments

@a-siva
Copy link
Contributor

a-siva commented Jun 8, 2021

commit(s) to merge: f827c53

merge instructions: clean merge

What is the issue: Brief description of the problem

Recent upgrade to bionic has caused an OOM test to start failing because the OS now does not result in an error from malloc when allocating 1 TB and the test relies on that. The test was changed to allocate 1 PB of memory.

This changes makes the test allocate 1 PB of memory and that triggers a failure in malloc.

Why cherrypick: The stable release bots are showing test result failures and fixing this will enable us to look for real failures as opposed to this synthetic test failure.

Risk: Very low, it is just a change to the test

Link to original issue(s): #46167

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow @a-siva @aam

@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-review Issue that need cherry pick triage to approve labels Jun 8, 2021
@franklinyow franklinyow added the cherry-pick-approved Label for approved cherrypick request label Jun 8, 2021
@franklinyow
Copy link
Contributor

Approved in SCRUM
CC: @kf6gpe change in test only

@athomas
Copy link
Member

athomas commented Jun 9, 2021

Merged to stable in 516eb3b (2.13.3).

@athomas athomas closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve
Projects
None yet
Development

No branches or pull requests

3 participants