Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP][stable channel] Fix an analyze crash when analyzing against package:meta v1.4.0 #46210

Closed
devoncarew opened this issue Jun 1, 2021 · 3 comments
Assignees
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable

Comments

@devoncarew
Copy link
Member

devoncarew commented Jun 1, 2021

commit(s) to merge: COMMIT-HASH

merge instructions: clean merge or patch CL

  • assumed clean merge

What is the issue: Brief description of the problem

The analyzer in stable was built against package:meta 1.3.0. A value was added to a package:meta enum in meta 1.4.0; if the current stable analyzer analyzes code (that uses the 'targetkind' annotation), and the user code is using meta 1.4.0, the analyzer will crash.

What is the fix: Brief description of the fix

This fix improves the enum lookup for this situation to be based on the name of the enum and not the index of the enum.

Why cherrypick: Describe the reasons, like many users impacted, or serious functional issues, for example

This is a small fix, and many people using analyzer stable, but resolving their code against the recently released package:meta 1.4.0, will see analyzer crashes.

Risk:

  • low

Link to original issue(s):

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow


@devoncarew devoncarew added merge-to-stable cherry-pick-review Issue that need cherry pick triage to approve labels Jun 1, 2021
@franklinyow franklinyow added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Jun 1, 2021
@franklinyow
Copy link
Contributor

@kf6gpe

@franklinyow franklinyow added the cherry-pick-approved Label for approved cherrypick request label Jun 3, 2021
@franklinyow
Copy link
Contributor

Description:
Fix an analyze crash when analyzing against package:meta v1.4.0 , see #46183 for detail

@athomas
Copy link
Member

athomas commented Jun 9, 2021

Merged to stable in 516eb3b (2.13.3).

@athomas athomas closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable
Projects
None yet
Development

No branches or pull requests

3 participants