Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP][stable channel] Bug-fix for bug in CastMap #45990

Closed
lrhn opened this issue May 12, 2021 · 6 comments
Closed

[CP][stable channel] Bug-fix for bug in CastMap #45990

lrhn opened this issue May 12, 2021 · 6 comments
Assignees
@athomas
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable

Comments

@lrhn
Copy link
Member

lrhn commented May 12, 2021

commit(s) to merge: 5b64d12

merge instructions: clean merge

What is the issue: A cast in CastMap was incorrectly doing as V instead of as V?. This made otherwise valid code throw in some situations.

What is the fix: Changed to as V?, which allows null to be a value in the cast map.

Why cherrypick: It's a very simple and painless fix for a reported bug (meaning someone has already hit it).

Risk: None. Only difference is that some code which would incorrectly throw will now work correctly.

Link to original issue(s): #45473

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow
@lrhn lrhn added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. merge-to-beta cherry-pick-review Issue that need cherry pick triage to approve labels May 12, 2021
@lrhn lrhn added this to the April release (beta) milestone May 12, 2021
@leafpetersen
Copy link
Member

LGTM

@vsmenon
Copy link
Member

vsmenon commented May 13, 2021

lgtm

@franklinyow franklinyow changed the title [CP][beta channel] Bug-fix for bug in CastMap [CP][stable channel] Bug-fix for bug in CastMap May 13, 2021
@franklinyow
Copy link
Contributor

We are approving this for 5/21 window

@franklinyow franklinyow added the cherry-pick-approved Label for approved cherrypick request label May 13, 2021
@franklinyow franklinyow removed this from the April release (beta) milestone May 13, 2021
@franklinyow
Copy link
Contributor

Description:
Fix an incorrect behavior in CastMap, see #45473 for detail

@franklinyow
Copy link
Contributor

cc: @kf6gpe

@athomas
Copy link
Member

athomas commented May 21, 2021

Merged to stable 375a2d7 (2.13.1).

@athomas athomas closed this as completed May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athomas athomas

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@vsmenon @lrhn @leafpetersen @athomas @franklinyow