Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cp][stable] Cherry-pick fix to secure socket connection unhandled exception #45214

Closed
aam opened this issue Mar 5, 2021 · 6 comments
Closed

[cp][stable] Cherry-pick fix to secure socket connection unhandled exception #45214

aam opened this issue Mar 5, 2021 · 6 comments
Assignees
@athomas
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable

Comments

@aam
Copy link
Contributor

aam commented Mar 5, 2021

Please cherry-pick https://dart.googlesource.com/sdk/+/ea3dfc9ac4617ad0346b515596636a1089ecc8a1 into stable.

This fixes "Bad state: Future already completed" unhandled exception that arises in cases when https connection attempt errors out or is aborted shortly after it started, before name resolution had a chance to complete. Original issue #45047.

The commit merges cleanly into stable.

/cc @mraleph @a-siva @franklinyow @vsmenon
@aam aam added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. merge-to-stable cherry-pick-review Issue that need cherry pick triage to approve labels Mar 5, 2021
@mraleph
Copy link
Member

mraleph commented Mar 5, 2021

Note for CP approvers: the reason for requesting a cherry pick is because this can cause sporadic crashes on pub (most likely because pub speculatively fans out multiple concurrent requests and sometimes cancels them). Sporadic crashes when running pub is bad user experience.

@athomas athomas assigned franklinyow and unassigned athomas Mar 5, 2021
@franklinyow
Copy link
Contributor

ping: @vsmenon @a-siva @mit-mit

@a-siva
Copy link
Contributor

a-siva commented Mar 9, 2021

lgtm

1 similar comment
@vsmenon
Copy link
Member

vsmenon commented Mar 9, 2021

lgtm

@franklinyow franklinyow added the cherry-pick-approved Label for approved cherrypick request label Mar 9, 2021
@franklinyow franklinyow assigned athomas and unassigned franklinyow Mar 9, 2021
@franklinyow
Copy link
Contributor

franklinyow commented Mar 9, 2021 •
edited
Loading

Hot-fix approved.

Text: This fixes "Bad state: Future already completed" unhandled exception that when https connection attempt errors out, or when aborted shortly after it started, before name resolution had a chance to complete, see issue #45047.

@franklinyow
Copy link
Contributor

Hot fix 2.12.1

@chinmaygarde chinmaygarde mentioned this issue Mar 15, 2021
Closed
@mraleph mraleph mentioned this issue Mar 23, 2021
Closed
@kuhnroyal kuhnroyal mentioned this issue Nov 28, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athomas athomas

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mraleph @aam @vsmenon @a-siva @athomas @franklinyow