Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Please merge 86f3fde23fac9684f99200841f95db60bab79d20 into stable channel #42112

Closed
mraleph opened this issue May 29, 2020 · 3 comments
Closed

[CP] Please merge 86f3fde23fac9684f99200841f95db60bab79d20 into stable channel #42112

mraleph opened this issue May 29, 2020 · 3 comments
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable

Comments

@mraleph
Copy link
Member

mraleph commented May 29, 2020

commit(s) to merge: 86f3fde

merge instructions: https://dart-review.googlesource.com/c/sdk/+/149420

reason: This CL fixes a problem where persistent front-end process used for incremental compilation during development would leak more and more memory with each recompilation. The amount of leaked memory depends on which parts of their app user is editing. As an experiment editing 20 files in flutter framework and reloading after each caused FE server to leak 3GB. This is believed to be the cause of some reports in #41862

/cc @franklinyow
@mraleph mraleph added merge-to-stable area-front-end Use area-front-end for front end / CFE / kernel format related issues. cherry-pick-review Issue that need cherry pick triage to approve labels May 29, 2020
@franklinyow franklinyow added the cherry-pick-approved Label for approved cherrypick request label Jun 1, 2020
@franklinyow
Copy link
Contributor

Dart approved

@pcsosinski
Copy link

Flutter approved (@tvolkert)

@pcsosinski pcsosinski mentioned this issue Jun 3, 2020
Closed
@athomas
Copy link
Member

athomas commented Jun 9, 2020

Merged as 5279388 and released in 2.8.4.

@athomas athomas closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mraleph @athomas @franklinyow @pcsosinski