Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Please partially merge #17f62d3f3ae56a1d76cbcb4410ea0ca884677c45 into stable channel #41907

Closed
mraleph opened this issue May 15, 2020 · 4 comments
Closed

[CP] Please partially merge #17f62d3f3ae56a1d76cbcb4410ea0ca884677c45 into stable channel #41907

mraleph opened this issue May 15, 2020 · 4 comments
Assignees
@athomas
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable

Comments

@mraleph
Copy link
Member

mraleph commented May 15, 2020 •
edited by franklinyow
Loading

commit(s) to merge: 17f62d3

merge instructions: https://dart-review.googlesource.com/c/sdk/+/148127 - to limit cherry pick to a single line flag change

reason: This change addresses regression in stack trace quality on Flutter stable channel - without this change users will see "optimized out" instead of function names for some of the frames in the stack trace.

/cc @dgrove @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow @pcsosinski
@mraleph mraleph added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-review Issue that need cherry pick triage to approve labels May 15, 2020
@mraleph
Copy link
Member Author

mraleph commented May 15, 2020

/cc @mkustermann @sstrickl

@franklinyow franklinyow added the cherry-pick-approved Label for approved cherrypick request label May 19, 2020
@franklinyow
Copy link
Contributor

Approved: regression, low risk
Wait for join approval, do not merge yet

@tvolkert
Copy link
Contributor

flutter eng approval +1

@athomas athomas assigned athomas and unassigned franklinyow May 26, 2020
@franklinyow
Copy link
Contributor

closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athomas athomas

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mraleph @tvolkert @athomas @franklinyow