No completion for "call" method on Function objects

[shinayser]

At the current version of dart sdk (2.7.0) we don't have a completion for the "call" method for function types. This is leading to third party sollutions to fix this problem, as of: simc/dartx#16 (comment)

[pq]

WIP (https://dart-review.googlesource.com/c/sdk/+/132920):

Note that since call has no backing element (in the analyzer's element model) it is not rendered w/ the method icon (or return type displayed). If this is significant, we'll want to accommodate this special case on the client(s) side(s) (e.g., IntelliJ and VS Code).

[pq]

Issue tracking IntelliJ cosmetics: https://youtrack.jetbrains.com/issue/WEB-43413.

/fyi @DanTup in case you want to track this for VS Code.

[DanTup]

@pq thanks! I'll try it out and see how it looks. If I understand that issue correctly, the reason it doesn't appear the same is that IntelliJ is using its own data structures for this? In VS Code everything comes from the server, so if this shows up like any other method, I'd expect it to just work. I'll give it a test to confirm though!

[pq]

Thanks @DanTup. The issue is that ordinary method suggestions have a method element associated with them and that's how clients know it's a method invocation. These do not (since call isn't part of the actual element model and is a kind of magic method). To clients these will just look like invocations but the logic they use to decorate them as methods (vs. property accessors for example), won't "just work" and so we'll need to special case them I think.

Feel free to ping me if you hit any snags.

[bwilkerson]

Could we do the special casing on the server side (by sending the information we would have sent had there been an element for it)?

[pq]

Ah, OK. @bwilkerson, yes. I was being thick. Looking at this again, I think we can. Will follow-up...

[pq]

@DanTup: please ignore, I've got a fix in flight on the server side. Everything should now "just work". Sorry for the noise!

[DanTup]

@pq np, and thanks! Is it https://dart-review.googlesource.com/c/sdk/+/133001? If so, is there anything special I need to do to see this? Using the most recent nightly (2.8.0-edge.a4aaaf05eb34bc07686f7480a0da7f056f284b91 (Fri Jan 24 11:40:59 2020 +0000)) I don't see the call() completion:

[DanTup]

Oops, user error. I was using the a sample project that was pointing at running the analyzer from source (and my local folder wasn't up-to-date) 🙈

Looks as expected :-)

[pq]

Sweet!