Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span.getLocationMessage returns incorrect output for lines without trailing newlines #19665

Closed
nex3 opened this issue Jun 26, 2014 · 1 comment
Closed

Span.getLocationMessage returns incorrect output for lines without trailing newlines #19665

nex3 opened this issue Jun 26, 2014 · 1 comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. pkg-sourcemaps

Comments

@nex3
Copy link
Member

nex3 commented Jun 26, 2014

If a span points to the final line in a file, and that line doesn't end in a newline, the arrows in getLocationMessage will be rendered on the same line as the source text. For example:

    Error on line 12, column 28 of pubspec.yaml: Error loading transformer: I hate these settings!
      - app/src/html_rewriter: {} ^^
@nex3 nex3 added Type-Defect pkg-sourcemaps area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Jun 26, 2014
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/source_maps#10.

@DartBot DartBot closed this as completed Jun 5, 2015
@DartBot DartBot mentioned this issue Jun 5, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. pkg-sourcemaps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nex3 @kevmoo @DartBot