Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server side api has Cookie, please add to client side api #19005

Closed
trinarytree opened this issue May 23, 2014 · 5 comments
Closed

server side api has Cookie, please add to client side api #19005

trinarytree opened this issue May 23, 2014 · 5 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug

Comments

@trinarytree
Copy link

https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart-io.Cookie
seems to only be available to the server.

that forces other libraries, e.g.
https://docs.angulardart.org/#angular-core.Cookies to implement their own;
or (gasp) the app level code must use the document.cookie api directly.

the angular one isn't nearly as comprehensive as the dart one, e.g.
it doesn't fully support cookie path or expiration dates
(it has really limited support for cookie path).
but really, angular shouldn't have to write such a library,
it should be in dart. you guys already wrote 90% of the code,
you should just share some of it with the client side.
i don't want to have to implement my own crazy DateTime to cookie-date converters.

@kevmoo
Copy link
Member

kevmoo commented May 25, 2014

We're looking at unifying some http code across client and server. This would be a great candidate.


cc @nex3.
cc @sgjesse.
cc @mkustermann.
Added Type-Enhancement, Area-Pkg, Pkg-Http_parser, Triaged labels.

@kevmoo
Copy link
Member

kevmoo commented May 25, 2014

@sgjesse
Copy link
Contributor

sgjesse commented May 26, 2014

We should consolidate the HTTP utility functions we have. What is already in dart:io should somehow be available in a package for browser use.

@nex3
Copy link
Member

nex3 commented May 27, 2014

Removed Pkg-Http_parser label.
Added Pkg-Http label.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/http#20.

@DartBot DartBot closed this as completed Jun 5, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants