Skip to content

Commit

Permalink
[stable] [vm/debugger] Use safepoint-safe RwLock for breakpoint locat…
Browse files Browse the repository at this point in the history
…ions locks and Ensure setting breakpoints is lock-safe.

TEST=DartAPI_BreakpointLockRace and DeoptimizeFramesWhenSettingBreakpoint

Fixes
#54650
flutter/flutter#140878

Acquire reload opreation scope when deoptimizing the world to ensure locks can be acquired for compilation.
Set up scope for operations that can be run while the world is deoptimized and stopped to avoid races.
Ensure code stays unoptizimed when single stepping, prevent other isolates to reoptimize.

Bug: #54650 and flutter/flutter#140878
Change-Id: I9a88096f15a34b645281e5b2b3805a73dd93672e
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/347420 and https://dart-review.googlesource.com/c/sdk/+/345743
Cherry-pick-request: #54699
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/347650
Reviewed-by: Alexander Aprelev <[email protected]>
Commit-Queue: Kevin Chisholm <[email protected]>
  • Loading branch information
a-siva authored and Commit Queue committed Jan 23, 2024
1 parent bc253dc commit fce4255
Show file tree
Hide file tree
Showing 7 changed files with 375 additions and 62 deletions.
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
## 3.2.6 -

This is a patch release that:
- Fixes an issue that causes Flutter apps to freeze when breakpoints
are added to multiple isolates at the same time
It also Fixes an issue that causes Flutter apps to crash during hot
reload
(issue [54699][]).

[#54699] - https://github.com/dart-lang/sdk/issues/54699

## 3.2.5 - 2024-01-17

This is a patch release that:
Expand Down
Loading

0 comments on commit fce4255

Please sign in to comment.