Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffigen] Should we include -Wno-nullability-completeness compiler option by default? #1073

Closed
dcharkes opened this issue Apr 4, 2024 · 2 comments · Fixed by #1074
Closed

Comments

@dcharkes
Copy link
Collaborator

dcharkes commented Apr 4, 2024

I can't run flutter create --template=plugin_ffi my_package and then dart run ffigen --config ffigen.yaml locally on MacOS without adding:

compiler-opts:
  - '-Wno-nullability-completeness'

We can add this to the Flutter template, but it looks like we're littering this line across the all your ffigen.yamls to make it work in the repository.
So maybe we should just add it by default if it can't do any harm.

@dcharkes
Copy link
Collaborator Author

dcharkes commented Apr 4, 2024

wdyt @mannprerak2 @liamappelbe ?

@mannprerak2
Copy link
Contributor

Probably yeah, it would reduce a ton of warning logs.

I don't think this flag does anything other than skip warnings. So we probably don't need to increment the major version as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants