-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure http/browser_client.dart in http package to avoid dart:mirrors usage (?) #25
Comments
<img src="https://avatars.githubusercontent.com/u/1047298?v=3" align="left" width="48" height="48"hspace="10"> Comment by Scorpiion To be clear, a simple Hello World app importing package:http/browser_client.dart gives this: * Your app imports dart:mirrors via:
|
<img src="https://avatars.githubusercontent.com/u/4865287?v=3" align="left" width="48" height="48"hspace="10"> Comment by lrhn Removed Type-Defect label. |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 The warning sucks, but in practice the usage of mirrors in the http package is harmless. It's only used to determine that dart:io is unavailable, and adds essentially no size overhead to the compiled output. I'd love to remove mirrors from the package, but right now the language just doesn't support it while maintaining the same API. Marked this as being blocked by dart-lang/sdk#6943. |
The usage of mirrors makes it impossible to use this lib with flutter (which disables mirrors). |
Yes. We had to fork http here: https://github.com/flutter/flutter/blob/master/packages/flutter/lib/http.dart |
Disabling mirrors makes sense, but making programs statically invalid just by importing |
I'm merging this as a duplicate of #1. |
Blocked by dart-lang/sdk#24581
The text was updated successfully, but these errors were encountered: