Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http package does not expose HttpClient capabilities but keeps the backing instance private at the same time #19

Closed
DartBot opened this issue Jun 5, 2015 · 3 comments
Assignees
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

Originally opened as dart-lang/sdk#18871

This issue was originally filed by [email protected]


What steps will reproduce the problem?

  1. Import the built in package with: import 'package:http/http.dart';
  2. Try to issue a request against a host which has SSL problems, in my case SEC_ERROR_UNKNOWN_ISSUER ( see https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/SSL_functions/sslerr.html )
  3. Watch it fail with a handshake problem

What is the expected output? What do you see instead?

I'd expect the http package to expose the setter for the backing HttpClient badCertificateCallback somehow.

To solve my use-case the easiest would be to publicise the currently private variable ( called _inner in io_client.dart ) but I can see how some people would oppose that.

What version of the product are you using? On what operating system?
Dart Stable 1.3.6, it's the same in 1.4.0-edge.36282
OS X Mavericks 10.9.2

Please provide any additional information below.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/17034?v=3" align="left" width="48" height="48"hspace="10"> Comment by kevmoo


cc @nex3.
Added Area-Pkg, Pkg-Http, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Set owner to @nex3.
Added Started label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Fixed in dart-lang/sdk@6d63acf and released as version 0.11.1.


Added Fixed label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants