Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the reference to play-services-cronet in example/android/app/build.gradle for package:cronet_http_embedded #1102

Closed
brianquinlan opened this issue Jan 2, 2024 · 0 comments · Fixed by #1103
Closed

Remove the reference to play-services-cronet in example/android/app/build.gradle for package:cronet_http_embedded #1102

brianquinlan opened this issue Jan 2, 2024 · 0 comments · Fixed by #1103
Assignees
@brianquinlan
Labels
package:cronet_http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@brianquinlan
Copy link
Collaborator

brianquinlan commented Jan 2, 2024 •
edited
Loading

This causes the tests to fail with duplicate symbols because the example uses com.google.android.gms:play-services-cronet and package:cronet_http uses org.chromium.net:cronet-embedded.
@brianquinlan brianquinlan added type-enhancement A request for a change that isn't a bug package:cronet_http labels Jan 2, 2024
@brianquinlan brianquinlan self-assigned this Jan 2, 2024
@brianquinlan brianquinlan added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed type-enhancement A request for a change that isn't a bug labels Jan 2, 2024
@brianquinlan brianquinlan mentioned this issue Jan 2, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianquinlan brianquinlan

Labels
package:cronet_http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
1 participant
@brianquinlan