Fix bug around ref resolution of type mentioned in type arguments

[srawlins]

Fixes #3758

The main fix is in method.dart, when finding "elements nearby" a method, we were including the ElementType for things like "type arguments in the return type," as in Vehicle in Future<Vehicle>. But the ElementType does not have an href; it has a ModelElement which does have an href.

I also simplify a few things:

• Also in method, we were looking at the "type arguments" of a method declartion, but this is implemented in the ElementType hierarchy to be const []. Oy. OK, removed.
• A recent refactor meant that allowTree was only ever (_) => true, so I scrapped that parameter in a few functions, simplfying everything.

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[srawlins]

flutter bot still failing with "dartdoc 8.0.8 (/home/runner/work/dartdoc/dartdoc/.dart_tool/pub/bin/dartdoc/dartdoc.dart-3.5.0-138.0.dev.snapshot) failed: Command executables must exist. The file "/tmp/flutterNMVXCR/bin/cache/artifacts/snippets/snippets" does not exist for tool snippet." unrelated to this change.

[srawlins]

Hey @bwilkerson @kallentu , my initial plan with Kallen's move was to keep sending her reviews, as she is currently the person with the 2nd most dartdoc knowledge. But I think it's actually important to bring that knowledge back in-house, as it were, so I need a new primary reviewer on the analyzer team :D I added you @bwilkerson sort of as a default, but we can discuss who should primarily get dartdoc reviews.

[kallentu]

Thanks for making this part of the lookup more readable than it was.

Regarding spreading the knowledge in the analyzer team, I think that's a great idea! Would take a lot of weight off your shoulders too. I'm happy to still be cc'd on reviews though. I have good amount of vested interest in Dartdoc now haha

[kallentu]

👍
I'm excited to tear all of this out with the analyzer's resolution.