-
Notifications
You must be signed in to change notification settings - Fork 6
clean up ChangeRecord API #49
Comments
<img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="48" height="48"hspace="10"> Comment by jmesserly Removed this from the M8 milestone. |
<img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="48" height="48"hspace="10"> Comment by jmesserly first step here: Set owner to @jmesserly. |
<img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="48" height="48"hspace="10"> Comment by jmesserly Update: all issues are fixed except splitting out MapChangeRecord and adding "object" to it. Removed the owner. |
<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch Removed this from the Later milestone. |
<img src="https://avatars.githubusercontent.com/u/8616782?v=3" align="left" width="48" height="48"hspace="10"> Comment by clayberg Removed this from the M9 milestone. |
<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch Removed this from the 1.1 milestone. |
<img src="https://avatars.githubusercontent.com/u/3276024?v=3" align="left" width="48" height="48"hspace="10"> Comment by anders-sandholm Removed Library-Observe label. |
<img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="48" height="48"hspace="10"> Comment by jmesserly Removed Area-Polymer label. |
<img src="https://avatars.githubusercontent.com/u/2156198?v=3" align="left" width="48" height="48"hspace="10"> Comment by kasperl Removed this from the 1.2 milestone. |
<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch Removed Priority-Unassigned label. |
<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch Removed this from the 1.6 milestone. |
<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch Removed Polymer-P-1 label. |
<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch Removed Polymer-Milestone-Next label. |
<img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="48" height="48"hspace="10"> Comment by jmesserly Added MovedToGithub label. |
<img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="96" height="96"hspace="10"> Issue by jmesserly
Originally opened as dart-lang/sdk#14157
* Observable.changes should only be property changes.
ObservableList will have "listChanges" property which includes the ListChangeRecords.
Splitting this allows the consumer to know what kind of records it is getting, and makes the API constraints more clear.
* remove ChangeRecord base class
* add "target" to List/Map change record
* add old/new values to ListChangeRecord? See http://wiki.ecmascript.org/doku.php?id=harmony:observe#array.observe
The text was updated successfully, but these errors were encountered: