Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

consider splitting Observable into interface vs mixin #10

Open
jmesserly opened this issue Apr 1, 2015 · 2 comments
Open

consider splitting Observable into interface vs mixin #10

jmesserly opened this issue Apr 1, 2015 · 2 comments

Comments

@jmesserly
Copy link
Contributor

this would allow, e.g. implements Observable or with ChangeNotifier without transitively importing mirrors. I'm not sure this is necessary given that we use the standard https://github.com/dart-lang/smoke solution, and an improved https://github.com/dart-lang/reflectable is on the way, but maybe as a temporary solution for some customers.

@jmesserly
Copy link
Contributor Author

on second thought, we should definitely do this. The current Observable mixes protected methods and interface methods. That's no good. Thanks to @matanlurey for catching this.

@jmesserly
Copy link
Contributor Author

also while we're at it, we should add @protected annotations or make sure the documentation is really clear

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant