Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Breaking: Template Urls should not start with '/' #1707

Open
jrote1 opened this issue Apr 7, 2015 · 2 comments
Open

Breaking: Template Urls should not start with '/' #1707

jrote1 opened this issue Apr 7, 2015 · 2 comments

Comments

@jrote1
Copy link
Contributor

jrote1 commented Apr 7, 2015

In 1.1.1 template urls were changed
from: packages/app/modules/main_component.html
to: /packages/app/modules/main_component.html

This is a breaking change and should be changed to not start with '/' by default this has broken my app and most likely other peoples as well. Should be fixed urgently. The commit that introduced this by the looks of it is @73b4153fad623a01eac25bd6f9a6b3489f2f5cd6

@jrote1
Copy link
Contributor Author

jrote1 commented Aug 28, 2015

@vicb Is anyone still checking on this version of angular?

@TedSander
Copy link
Contributor

Sorry can I get more context into this? I tried to reproduce it for a couple hours and got nowhere. I tried a small use case and I can't get it to rewrite in this way.

Some other notes:
a) If you don't care about type relative URIs I would suggest setting this config:
bind( ResourceResolverConfig, toValue: new ResourceResolverConfig.resolveRelativeUrls(false));
This is going to leave the URIs unchanged.
b) If you can I would switch to type relative URIs they are really nice to work with. example
c) Try turning on template cache for production by adding generate_template_cache: true to your angular2 transformer.
d) The packages symlink is actually going away in a future version of dart eventually, but currently pub serve and the transformers understand them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants