Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Resolve relative URL issue #1455

Open
vicb opened this issue Sep 15, 2014 · 4 comments
Open

Resolve relative URL issue #1455

vicb opened this issue Sep 15, 2014 · 4 comments
Assignees
Milestone

Comments

@vicb
Copy link
Contributor

vicb commented Sep 15, 2014

When I try to pub build and have a folder named "include-gh1415", the URI resolver will throw:

[Error from Dart2JS]:
web/include-gh1415/main_static_type_to_uri_mapper.dart:1:34:
Expected ';' after this.
library angular_dart_example.web.include-gh1415.main.generated_type_uris;
                                 ^^^^^^^
[Error from Dart2JS]:
web/include-gh1415/main_static_type_to_uri_mapper.dart:1:41:
Can't have modifier '-' here.
Try replacing modifier '-' with 'var', 'final', or a type.
library angular_dart_example.web.include-gh1415.main.generated_type_uris;
                                        ^
[Error from Dart2JS]:
web/include-gh1415/main_static_type_to_uri_mapper.dart:3:1:
Library tags not allowed here.
import 'package:angular/core_dom/type_to_uri_mapper.dart';
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[Info from Dart2JS]:
Took 0:00:00.004174 to compile angular_dart_example|web/include-gh1415/main_static_type_to_uri_mapper.dart.
[Info from Dart2JS]:
Compiling angular_dart_example|web/include-gh1415/main.dart...
[Error from Dart2JS on angular_dart_example|web/include-gh1415/main.dart]:
web/include-gh1415/main_static_type_to_uri_mapper.dart:1:34:
Expected ';' after this.
library angular_dart_example.web.include-gh1415.main.generated_type_uris;
                                 ^^^^^^^
[Error from Dart2JS on angular_dart_example|web/include-gh1415/main.dart]:
web/include-gh1415/main_static_type_to_uri_mapper.dart:1:41:
Can't have modifier '-' here.
Try replacing modifier '-' with 'var', 'final', or a type.
library angular_dart_example.web.include-gh1415.main.generated_type_uris;
                                        ^
[Error from Dart2JS on angular_dart_example|web/include-gh1415/main.dart]:
web/include-gh1415/main_static_type_to_uri_mapper.dart:3:1:
Library tags not allowed here.
import 'package:angular/core_dom/type_to_uri_mapper.dart';
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@chirayuk @dsalsbury please have a look at this

@vicb
Copy link
Contributor Author

vicb commented Sep 15, 2014

How to reproduce:

  • move the hello_word dart & html files to a "hello-world" subfolder,
  • execute pub build in the example folder

@naomiblack
Copy link
Contributor

@vicb can you make a PR to fix this without rolling back? Is this still an issue?

@vicb
Copy link
Contributor Author

vicb commented Oct 7, 2014

I can't remember having seen a PR fixing that (or any other related issue)
@chirayuk was looking into this (which is why the issue was assigned to him).

@naomiblack
Copy link
Contributor

I'm deferring to post-1.0 until someone has time to work on a PR addressing this. Out of scope for 1.0.

@naomiblack naomiblack modified the milestones: post v1.0, v1.0 Oct 8, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants