Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Directive Injector incorrectly computes direct childe visibility #1294

Open
mhevery opened this issue Jul 31, 2014 · 0 comments
Open

Directive Injector incorrectly computes direct childe visibility #1294

mhevery opened this issue Jul 31, 2014 · 0 comments
Milestone

Comments

@mhevery
Copy link
Contributor

mhevery commented Jul 31, 2014

imagine you have tabs and pane directives where pane has to be a direct child of tabs

<tabs>
  <pane title="Overview"> foo text </pane>
</tabs>

The above works, but so does this:

<tabs>
  <div>
    <pane title="Overview"> foo text </pane>
  </div>
</tabs>

but it should not. It works because div has no associated injector and so pane thinks it is a child of tabs

the strange part is that by adding a directive to div it will create a new injector and break the direct parent/child relationship between tabs and pane

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants