-
Notifications
You must be signed in to change notification settings - Fork 248
chore: install paper_elements & core_elements from pub #1479
Conversation
There is an issue as the expression extractor will extract expression from paper elements now (polymer also uses mustache). |
@jbdeboer I've added a second commit to fix the generator. I'm curious to know if this will work with g3. If not we could be more specific on the folder we want to blacklist. This commit could could help making the generator step faster. |
@jbdeboer can you review and approve/comment, or else defer to post-1.0? |
Angular itself does not depend on paper_elements, so it should not be in the main pubspec. The question is whether it should go in the That said, this is something that you feel strongly about. Perhaps we can come up with additional or different demos and clarify the intent. |
@jbdeboer The deps should be in the examples pubspec, this is a mistake on my side. I think this change (once the deps are moved at the right) is good because:
Without this change user won't be able to use pub (because of version conflicts) and will be forced to use bower. I don't get the part about adding more demos. I think this change could make our users happier. Let me know if I need to update this PR (wrt example pubspec) and any other thing I need to update or if this is not worth it. |
@jbdeboer this needs a decision to merge or should be closed. Can you make the final call please? |
Your first point of forcing compatibility is excellent. We should do that, but we should do it in another example project, so that we have demos of:
I am closing this PR. @vicb, if you would like to add a new AngularDart <-> PolymerDart example, please open a new PR. |
fixes #1281
fixes #1283