Add support for Brave Browser #250
Comments
|
Seconded. Meanwhile, a workaround is: duplicate another browser's entry, then modify the name and path. For the image, a take manually downloaded picture. |
OrientationFour files at https://github.com/darktrojan/openwith/tree/master/webextension/native
CollaborationFrom #256 (comment):
tl;dr Waterfox Current is based on Firefox ESR 68. Content of the patch from #250 (comment) above: --- open_with_linux.bak.py 2019-11-16 15:21:01.764783997 -0600
+++ open_with_linux.py 2019-11-16 15:49:57.092113557 -0600
@@ -63,6 +63,7 @@
}
locations = {
'chrome': os.path.join(home_path, '.config', 'google-chrome', 'NativeMessagingHosts'),
+ 'brave': os.path.join(home_path, '.config', 'BraveSoftware', 'Brave-Browser-Dev', 'NativeMessagingHosts'),
'chromium': os.path.join(home_path, '.config', 'chromium', 'NativeMessagingHosts'),
'firefox': os.path.join(home_path, '.mozilla', 'native-messaging-hosts'),
}
@@ -114,6 +115,9 @@
apps = [
'Chrome',
'Chromium',
+ 'brave',
+ 'brave-browser',
+ 'brave-browser-dev',
'chromium-browser',
'firefox',
'Firefox', |
Aiming to fix darktrojan#250 * focusing first on Linux
This comment has been minimized.
This comment has been minimized.
|
@grahamperrin I'm not sure, but maybe you should also add |
Addition of `waterfox-current` re: darktrojan#250 (comment)
|
@grahamperrin Hi, I tried your modifications from your 7510cb2 commit, but it didn't do anything. I had to replace $ ls -ld ~/.config/BraveSoftware/Brave-Browser-Dev
ls: cannot access /home/abcdxyzt/.config/BraveSoftware/Brave-Browser-Dev: No such file or directory
$ ls -ld ~/.config/BraveSoftware/Brave-Browser
drwx------ 1 abcdxyzt abcdxyzt 1056 mars 14 02:36 /home/abcdxyzt/.config/BraveSoftware/Brave-Browser/ |
I managed to get this working in brave by installing from the Chrome Web Store, then adding the following to line 66 (under "def install()" and "locations") of open_with_linux.py:
'brave': os.path.join(home_path, '.config', 'BraveSoftware', 'Brave-Browser-Dev', 'NativeMessagingHosts'),For a while I was trying to use:
'brave': os.path.join(home_path, '.config', 'brave', 'NativeMessagingHosts'),For some reason on my system, both ~/.config/brave/NativeMessagingHosts and ~/.config/BraveSoftware/Brave-Browser-Dev/NativeMessagingHosts exist, but it was the latter that worked.
My Brave installation is a bit of a mystery to me these days, in that I generally launch Brave via the binary brave-browser-dev but brave-browser seems to load the same configuration, so it took a while before it even occurred to me to look for an alternate config path. You might want to account for both.
For purposes of adding a searchable paper trail to help others get here, with open_with.json installed in the wrong place, when I pressed Test Installation button in options.html, my Browser Console was yielding
options.html:1 Unchecked runtime.lastError: Specified native messaging host not found.Anyway, thank you for this awesome tool! I can't wait to tie it to some scripts ;)
addBraveSupport.patch.txt
The text was updated successfully, but these errors were encountered: