Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with --wait, parallelshell always exits with 0? #38

Closed
kentor opened this issue Oct 14, 2015 · 2 comments
Closed

with --wait, parallelshell always exits with 0? #38

kentor opened this issue Oct 14, 2015 · 2 comments

Comments

@kentor
Copy link

kentor commented Oct 14, 2015

Even if the subprocesses have an exit code > 0. Is this intended?

@kentor kentor changed the title --wait always exits with 0? with --wait, parallelshell always exits with 0? Oct 14, 2015
@keithamus
Copy link
Collaborator

That sounds like a bug. Have you tried using the dev branch (see #30)? If it fixes it for you, let me know and we can look to merging #30.

@kentor
Copy link
Author

kentor commented Oct 14, 2015

Master:

❯ npm start; echo $?

> @ start /Users/kenneth/stuff/parallelshell-test
> parallelshell --wait 'rm asdf'

rm: asdf: No such file or directory
0

exits 0.

Dev:

❯ npm start; echo $?

> @ start /Users/kenneth/stuff/parallelshell-test
> parallelshell --wait 'rm asdf'

0

exits 0. does not show the failed rm message?

without wait, this would exit 1

@kentor kentor closed this as completed Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants