Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclamation mark isn't tags as a sent-final punct #34

Open
NickZambrano opened this issue Apr 10, 2018 · 3 comments
Open

Exclamation mark isn't tags as a sent-final punct #34

NickZambrano opened this issue Apr 10, 2018 · 3 comments

Comments

@NickZambrano
Copy link

In the readme it says that the "!" should be tags as a sent-final punct (".")

In fact on my side it's tagged as "!" so if I console.log I got ["!","!"] and not ["!","."].

@Hugo-ter-Doest
Copy link

I think the problem is caused by the lexicon in lexicon.js. It assigns ! to !:

 "!": [
        "!"
    ],

If you change this to . it should work correctly.

Hugo

@NickZambrano
Copy link
Author

After looking in the code, I saw, but maybe the readme should be updated, right ?

@Hugo-ter-Doest
Copy link

I think the lexicon should be updated according to the README. The tags as defined in the README follow PENN Treebank tags.

Hugo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants