Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: we should add tests for the stateManagerCtx #446

Open
sicoyle opened this issue Sep 14, 2023 · 11 comments · May be fixed by #558
Open

test: we should add tests for the stateManagerCtx #446

sicoyle opened this issue Sep 14, 2023 · 11 comments · May be fixed by #558
Assignees
@KentHsu
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sicoyle
Copy link
Contributor

sicoyle commented Sep 14, 2023

Is your feature request related to a problem? Please describe.
https://github.com/dapr/go-sdk/blob/main/actor/state/state_manager.go is the only file in the state directory without tests. We should add tests to improve test coverage here.

Describe the solution you'd like
We need a state_manager_test.go file added testing the functionality of the stateManagerCtx.

Additional context
You can refer to the other test files in the state directory for inspiration and guidance to setup the tests for the state_manager_test.go.
@sicoyle sicoyle added the enhancement New feature or request label Sep 14, 2023
@pieramarchesini
Copy link

/assign

@sicoyle sicoyle moved this from Triaged to In Progress in Grace Hopper Conference 2023 Sep 22, 2023
@sicoyle
Copy link
Contributor Author

sicoyle commented Sep 22, 2023

adding links here from the chat :)

https://github.com/dapr/go-sdk/blob/e16e0350a52349b5a05138edc0b58e3be78ee753/service/http/health_check_test.go

go-sdk/client/client_test.go

Line 136 in e16e035

func getTestClient(ctx context.Context) (client Client, closer func()) {

Thank you for helping us improve the go sdk @pieramarchesini during the Grace Hopper Conference open source day event! 🙌

@daixiang0 daixiang0 added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 11, 2023
@sadath-12
Copy link
Contributor

/assign

@github-actions GitHub Actions
Copy link

⚠️ Unable to assign issue

@mikeee mikeee mentioned this issue Feb 20, 2024
Closed
@mikeee
Copy link
Member

mikeee commented Feb 20, 2024

@pieramarchesini @sadath-12 Heyo, are you both still working on adding some tests?

@KentHsu
Copy link

KentHsu commented Apr 30, 2024

Hi @mikeee, Is it okay if I take this one?

@mikeee mikeee assigned KentHsu and unassigned pieramarchesini and sadath-12 Apr 30, 2024
@mikeee
Copy link
Member

mikeee commented Apr 30, 2024

@KentHsu - Absolutely, thank you for picking this up!

@KentHsu
Copy link

KentHsu commented Apr 30, 2024

/assign

@github-actions GitHub Actions
Copy link

⚠️ Unable to assign issue

@mikeee
Copy link
Member

mikeee commented Apr 30, 2024

/assign

You're already assigned, it's all good 👍

@KentHsu KentHsu linked a pull request May 1, 2024 that will close this issue
Open
3 tasks
@KentHsu
Copy link

KentHsu commented May 1, 2024

/assign

You're already assigned, it's all good 👍

Didn't notice I was assigned when I typed it 😅
I created a PR for this issue. Please help to review it and let me know if I'm doing it correctly. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KentHsu KentHsu

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
Grace Hopper Conference 2023
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for stateManagerCtx KentHsu/go-sdk
6 participants
@KentHsu @pieramarchesini @mikeee @sicoyle @daixiang0 @sadath-12