Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate "close" behavior of pluggable component instances #39

Open
philliphoff opened this issue Aug 2, 2023 · 0 comments
Open
Labels
kind/engineering Improvements or additions to development process
Milestone

Comments

@philliphoff
Copy link
Collaborator

Runtime components can implement an optional Close() function called when the runtime is shutting down. This will serve as the basis for upcoming "hot reload" behavior in the runtime. It's not clear how this interacts with pluggable components, as none of the building block APIs have an explicit Close() function. While it's possible that the closure of the gRPC connection itself may serve as the signal for "closing" a component, it may not have quite the same meaning (e.g. an explicit closure by the runtime vs. a failure that results in the connection being closed). It might make more sense to have an explicit Close() function defined in the pluggable component APIs. (This would obviously be a breaking change, but given their current not-even-alpha state, would likely be acceptable.)

We need to spend some time investigating if and how to expose "close" behavior to pluggable component instances.

@philliphoff philliphoff added the kind/engineering Improvements or additions to development process label Aug 2, 2023
@philliphoff philliphoff added this to the v0.3.0 milestone Aug 22, 2023
@philliphoff philliphoff modified the milestones: v0.3.0, v0.4.0 Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Improvements or additions to development process
Projects
None yet
Development

No branches or pull requests

1 participant