[fixes #55] added support for enableAdvertisingIdCollection(boolean)

[mediavrog]

PR for #55 to support display advertisement features as described in https://support.google.com/analytics/answer/2444872.

Please check the IOS part, since I never touched any IOS project before. Also, what else would be needed to get started with this? The docs stated something about:

To use Google Analytics advertising features requires that you collect the IDFA (Identifier for Advertisers). To enable IDFA collection, link the libAdIdAccess.a and AdSupport.framework libraries to your application and set the allowIDFACollection property to YES on each tracker for which you want to enable advertising features.

I added the libAdIdAccess.a manually in the XCode build, and it seemingly works. I will have to verify with data after another 24 hours. Is there any way to add this file automatically during build?

[sltc-li]

Awesome!!! Thank you ...

👍 👎

[danwilson]

Thanks! I plan to verify the changes as soon as I have a free moment...
And yes @mediavrog, the plugin.xml is where we can put the libAdIdAccess.a to automatically add to the build.

[mediavrog]

@danwilson Thanks for the feedback.

Actually, I don't think the plugin should include this file automatically, because not everyone might want to include the Demographics tracking (I read Apple checks usage of this feature especially). Is there way for conditional inclusion?

[danwilson]

Very good point... I will research the best way to handle that. I know there are also command line options you can enable to be specified when a user adds the plugin... will need to see if that suits this case.

[Ballrock]

Unless I am mistaken, the method enableAdvertisingIdCollection() is not present in the Tracker class of libGoogleAnalyticsServices.jar... unlike google-play-services.jar...

So, merge that pull request on my fork generates "Cannot find symbol" errors at compilation.

[mediavrog]

@Ballrock Loocks like this method was added in SDK version 4, so I guess the library needs to be updated (https://developers.google.com/analytics/devguides/collection/android/v4/#tracking-methods)

According to the online docs there, there is no more standalone jar for the Analytics Android SDK, rather users should include the play services library now. Sorry about the incomplete PR then, lets find a solution together and update the PR

[Ballrock]

So we can maybe get the lib from import Google Play service for Android via SDK Manager.

I don't know if it's standalone but i've got the google-play-service.jar with the needed method at sdk\extras\google\google_play_services\libproject\google-play-services_lib\libs

But it seems that we need a little work to adapt the plugin to this new SDK library.

I will look at it in more detail tonight.

PS : Sorry but I only know about the Android side :(.

[danwilson]

I thought that might be the case with this feature... I am going to create a new issue to update to google play services for android... Which will involve modifying all the calls. We will get that in first and then circle back to this. Thanks!

[mediavrog]

Android update PR see #67

[Ballrock]

Now that #67 is merged we can return to this PR ;)

[felquis]

Awesome guys 💃

Any news about this PR?

[Ballrock]

I did some internals testing about this function after #67, it seems that it not work as expected 😞 Someone else tried ?

[zwacky]

+1

this is exactly what i am looking for. any more infos?

[vlaraort]

I am also looking for this functionality, are there any news? I tryied with the Ballrock solution but it gives "Invalid action" in console when trying to do enableAdvertisingIdCollection

[dkellycollins]

Is there any news on this? I'm looking to add this feature to my app.

[vanstinator]

Looking for this as well. @danwilson any chance this can get looked at again?

[chemerisuk]

According to the docs, you also need to link AdSupport.framework as well. Does it make sense?

[cmarrero01]

This bug it will be solve?.. I have this problem with my implementation of this plugin.

[vomchik]

any updates?

[victorsosa]

@mediavrog can you please fix the conflicts? to merge this as soon as possible.

[victorsosa]

@mediavrog can you please fix the conflicts? please

[Ballrock]

I think this need some tests before any thinking about merge...
I did some of them, last year, that has not been very successful.
On the other hand, I dont have enough userbase in my apps to see if it really work or not.

[victorsosa]

This was already merged #252