-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start the notary query when the tab loads #60
Comments
From MDN: "[using addProgressListener on a tabbrowser] will only get events from the browser [tab] that is currently displayed at the time the event occurs. In order to listen to events from all browsers, including those not currently being displayed [you must use gBrowser.addTabsProgressListener on the global browser]". "The progress listener should be based on the nsIWebProgressListener interface with an additional "browser" argument as the first argument of every method, which is the browser (not = gBrowser) where the event occurred." ref |
If you look at this gist: https://gist.github.com/lambdor/8824a4e04ad91373fda2 Yes, we could start the querying in But we could start querying even sooner on the first |
I implemented this now, but it's still work in progress, see the tabinfo_restructuring branch. |
Btw: I think we should split up the functionality even more. One file dealing with Perspectives core functionality and one file dealing with the client interaction. This would also allow for easier testing. |
Please try the new commit in tabinfo_restructuring! It should immediately start querying, handle redirects correctly (www.github.com -> github.com), respect "only contact on certificate security error" preference and update states when selecting a different tab. Whew! |
It looks like some queries actually don't start until the user views the tab? Verify if this is or isn't the case. If we're not starting the query right away we should try to - that will save time and make the extension more snappy/have a better UI.
The text was updated successfully, but these errors were encountered: