Upgrade Orval #1539
Merged
Upgrade Orval #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobArrow
force-pushed
the
DDFNEXT-205-upgrade-orval
branch
3 times, most recently
from
1a4c9a9 to
894e99a
Compare
JacobArrow
force-pushed
the
DDFNEXT-205-upgrade-orval
branch
from
894e99a to
3c2abff
Compare
kasperg
approved these changes
Nov 18, 2024
Previously we would invalidate react query with a manual override of autogenerated orval code. To avoid this we perform the invalidation inside the favourite component instead. There is no need to invalidate adding favourites, because we only have the option to remove favourites from the favourite list - elsewhere we update the state per material.
Instead of waiting for the request to complete, we remove the fill state optimistically
JacobArrow
force-pushed
the
DDFNEXT-205-upgrade-orval
branch
from
76ea7ae to
f03f073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-210
Description
button-favourite.tsxAt some point manual changes were made to the generated Orval files for material-list, and thus a rewrite of removing favourites was neccessary.