Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default font in admin.css overrides adminlte.css #843

Open
Joduai opened this issue Dec 8, 2024 · 1 comment
Open

default font in admin.css overrides adminlte.css #843

Joduai opened this issue Dec 8, 2024 · 1 comment
Labels

Comments

@Joduai
Copy link
Contributor

Joduai commented Dec 8, 2024

I was wondering why do every element utilizes sans-serif font along with text editor.
I thought that it's due to blocked external resources in my browser.
It turns out that /system/admin/editor/editor.css contains

body {
	font-family: Georgia, sans-serif;
}

that overrides the body font-family of adminlte's css.

Would be great if somebody confirms this having blocked external resources, as this is so small thing to fix (commenting or deleting from css) that making PR would be a nonsense.

btw. there are font files located in /system/resources/fonts but I see that external fonts are being loaded from google service in admin panel
https://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,400i,700
I didn't dig into it but does it make any sense, or is it just a fallback?

@Joduai Joduai added the bug label Dec 8, 2024
@danpros
Copy link
Owner

danpros commented Dec 9, 2024

Confirmed the /system/admin/editor/editor.css override the adminlte.css. It should only be in the text area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants