Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactor to proc macro code #49

Open
nicopap opened this issue Oct 25, 2023 · 1 comment
Open

Major refactor to proc macro code #49

nicopap opened this issue Oct 25, 2023 · 1 comment

Comments

@nicopap
Copy link
Contributor

nicopap commented Oct 25, 2023

Hello! Great crate you have here. I'm interested in using it, (actually I'm pushing to use it in bevy, and the community seems very open to it). I discuss why I'd like to use bitbybit in the following PR: bevyengine/bevy#10246

I've a lot of experience writing macros, and I think I can help divide by two the the number of lines of code for the macros. Would you be open to such a contribution?

You can check my coding style in the following files:

@danlehmann
Copy link
Owner

danlehmann commented Nov 7, 2023

Hey, I just merged your patch (f2f986f). Thanks again for your contribution! If you still want to do the refactoring for the main macro that would be fantastic.

Some items to be aware of, in case that changes any decisions on your end:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants