Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: how is isProbablyReaderable used? #13

Open
ManuelaJL opened this issue Mar 17, 2021 · 4 comments
Open

Question: how is isProbablyReaderable used? #13

ManuelaJL opened this issue Mar 17, 2021 · 4 comments

Comments

@ManuelaJL
Copy link

Hi. I can't quite see if you've got a java version of isProbablyReaderable, and how to use it.

My code is
            Readability4J readability4J = new Readability4J(url, html);
            Article article = readability4J.parse();

and I see there is no Readability4J.isProbablyReaderable() - Method. Is the method somewhere else?
Thanks

@dankito
Copy link
Owner

dankito commented Mar 23, 2021

Hi @ManuelaJL,

sorry, i didn't implement this method.

Are you interested in implementing it and giving me a pull request?

@ManuelaJL
Copy link
Author

Hm, I'll have to see if I have the time and skill for it. I don't know kotlin. Which of your implemented methods is the simplest to use as a model/example for learning how to port a method to java?

@dankito
Copy link
Owner

dankito commented Mar 26, 2021

It now came to my mind why i didn't implement this method: As Readability4J is really fast!

So you have the already the result and know if it's actually readable, not if it's "probably readable".

@diegode
Copy link

diegode commented Mar 27, 2021

Hi @dankito, thanks for this great library. The isProbablyReaderable method is not meant to be an optimization, but it's useful for cases in which automation is required, e.g. Firefox uses it to decide whether to show the "Toogle reader view" button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants