Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake error in 3.0.12 when building without C++ #2835

Closed
eschnett opened this issue Jan 10, 2025 · 7 comments
Closed

cmake error in 3.0.12 when building without C++ #2835

eschnett opened this issue Jan 10, 2025 · 7 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@eschnett
Copy link
Contributor

I am building Notcurses 3.0.12 with the options

FLAGS=(-DCMAKE_TOOLCHAIN_FILE=${CMAKE_TARGET_TOOLCHAIN}
       -DCMAKE_INSTALL_PREFIX=${prefix}
       -DCMAKE_BUILD_TYPE=Release
       -DBUILD_EXECUTABLES=ON
       -DBUILD_SHARED_LIBS=ON
       -DUSE_CXX=OFF
       -DUSE_DOCTEST=OFF
       -DUSE_MULTIMEDIA=${multimedia}
       -DUSE_PANDOC=OFF
       -DUSE_POC=OFF
       -DUSE_QRCODEGEN=OFF
       -DUSE_STATIC=OFF
       )

which specifies both -DUSE_CXX=OFF and -DUSE_STATIC=OFF.

This fails with the error:

[19:30:14] CMake Error at CMakeLists.txt:602 (target_compile_options):
[19:30:14]   Cannot specify compile options for target "notcurses++-static" which is not
[19:30:14]   built by this project.
[19:30:14]
[19:30:14]
[19:30:14] CMake Error at CMakeLists.txt:608 (target_compile_definitions):
[19:30:14]   Cannot specify compile definitions for target "notcurses++" which is not
[19:30:14]   built by this project.
[19:30:14]
[19:30:14]
[19:30:14] CMake Error at CMakeLists.txt:613 (target_compile_definitions):
[19:30:14]   Cannot specify compile definitions for target "notcurses++-static" which is
[19:30:14]   not built by this project.
@eschnett eschnett added the bug Something isn't working label Jan 10, 2025
@dankamongmen dankamongmen self-assigned this Jan 11, 2025
@dankamongmen dankamongmen added this to the 3.1.0 milestone Jan 11, 2025
@dankamongmen
Copy link
Owner

sacre bleu!

@dankamongmen
Copy link
Owner

do you happen to know whether this is a regression in 3.0.12? if not, no problem.

@dankamongmen
Copy link
Owner

verified in 3.0.12

@dankamongmen
Copy link
Owner

i think i've got a fix

@eschnett
Copy link
Contributor Author

Yes, this is a regression. It's not important at the moment – we have a patch and are using 3.0.12 just fine. I opened this issue mostly for future releases.

@dankamongmen
Copy link
Owner

no thank you very much for opening it! just if it's a regression (as indeed it is) i think that justifies a quick release to get the fix out.

@dankamongmen
Copy link
Owner

yeah i'm gonna put out 3.0.13 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants