Add multi-lingual inflectors and pluralize/singularize methods #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs tests, but needs discussion first.
This was referenced Oct 9, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several issues that have been opened about these methods, and then closed with the concern that they wouldn't be able to be multi-lingual.
I hope this approach will work. It is multi-lingual, new languages are easy to add (as long as one speaks the language and a bit of regex), and could be added on a project basis without needing to register anything with Stringy.
I have set up, to start, Inflectors for English, Spanish, French, Norwegian Bokmal, Portuguese and Turkish.
This still needs tests, but I just wanted to have a discussion first before I do those :)
For the record, I'd also be happy to update documentation before merging, both in terms of the methods and how to write/add a new inflector.