Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename identifier to data or params #41

Open
allaire opened this issue Mar 14, 2018 · 1 comment
Open

Rename identifier to data or params #41

allaire opened this issue Mar 14, 2018 · 1 comment

Comments

@allaire
Copy link

allaire commented Mar 14, 2018

Hi @danielrhodes,

I think it would be clearer to rename identifier to params or perhaps data in the create method (create(channel, identifier:, autoSubscribe:, bufferActions:). I see that the underlying API send identifier to the backend, but since name is a standalone parameter, I think it would make sense to abstract it a little bit more.

@allaire
Copy link
Author

allaire commented Mar 14, 2018

I can tackle this if you want, I suppose I should create a new method and add a deprecation warning on the other? Let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant