Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Hand Evaluation #9

Open
Mkey85 opened this issue Mar 30, 2020 · 2 comments
Open

Wrong Hand Evaluation #9

Mkey85 opened this issue Mar 30, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@Mkey85
Copy link

Mkey85 commented Mar 30, 2020

First of all, thanks for the create work!
I think I found a bug, I replaced the cards in the PokerDemo example and got this:

board: 9s 11c 3c 12c 8h

P1: 9c 5h
P2: 12h 4h
P3: 14d 13s
P4: 14s 13h

Winner: P1

But why? Do I oversee something?
Also I noticed that the range (Two Pairs, rank: [200, 300) for example) is usually over 300 (out of range)...
I had an example where a two pair lost against a single pair.

Thanks :)

@jakbrtz
Copy link

jakbrtz commented Apr 14, 2020

I also got a hand like that. I think the problem lies in EvaluateRankByHighestCards, specifically that excludeCardValue and excludeCardValue2 results in the high pairs not being counted towards the score.

EDIT: I set normalize (a parameter of EvaluateRankByHighestCards) to 10000000 and it appeared to have solved my problem.

@danielpaz6
Copy link
Owner

Sorry for the delay, I'll check it out.

@jakbrtz sounds interesting! I'll definitely check it and give a full answer to why it happens.
@Mkey85 wanted to let you know too.

@danielpaz6 danielpaz6 added the bug Something isn't working label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants