Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still compatibility issues with libsass? #10

Closed
zwilias opened this issue Jun 1, 2015 · 3 comments
Closed

Still compatibility issues with libsass? #10

zwilias opened this issue Jun 1, 2015 · 3 comments

Comments

@zwilias
Copy link

zwilias commented Jun 1, 2015

Hi,

bem-constructor still appears to have some issues with libsass compatibility, like it did with #8 but with different errors.

Particularly, it appears to fail over the use of selector-append(&...). This appears to be a sass-script feature which isn't very clearly documented anywhere. Hence, my question isn't really whether we can fix this on the bem-constructor side of things, but rather, to document the intended behavior of that construct so we can do a proper bug-report on the libsass side of things.

Anyone who could clarify what this specific syntax is actually intended to do?

Thanks!

@danielguillan
Copy link
Owner

Hi @zwilias,

The selector-append() function is not available in Libsass yet. Neither are any selector manipulation functions. The issue has already been filled and work is in progress. Support for selector manipulation functions should land in version 3.3 of Libsass: sass/libsass#963

We might be able to find a temporary workaround similar to the one I used on the Modernizr mixin which uses placeholders and extends to produce the selectors: https://github.com/danielguillan/modernizr-mixin/blob/master/stylesheets/_modernizr.scss#L64-L75

@danielguillan
Copy link
Owner

I've been trying to find a workaround to get the BEM Constructor working with Libsass, but unfortunately there are still many problems. Also, newer versions of Libsass introduced a regression that breaks the @at-root directive (sass/libsass/issues/1210) and make it totally impossible for the mixins to work.

I think we'll have to wait for Libsass 3.3. 😞

@danielguillan
Copy link
Owner

BEM Constructor now works with newer versions of Libsass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants