Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix applying lineCap value for line chart data sets (Fixes #3739) #3740

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Fix applying lineCap value for line chart data sets (Fixes #3739) #3740

merged 1 commit into from
Nov 15, 2018

Conversation

anton-filimonov
Copy link

DataSets for line chart have lineCap property which is supposed to be applied to the chart line. But it was applied only if dataSet is drawn in linear/stepped mode. This commit makes lineCap work for any existing mode.

Issue Link 🔗

#3739

Goals ⚽

Make it possible to use lineCap property of DataSet for line chart in any mode

Implementation Details 🚧

Moved setting lineCap to drawDataSet method

Testing Details 🔍

tested on sample app (just changed line width in example app and tried different combinations of mode-lineCap)

DataSets for line chart have lineCap property which is supposed to be applied to the chart line. But it was applied only if dataSet is drawn in linear/stepped mode. This commit makes lineCap work for any existing mode.
@codecov-io
Copy link

Codecov Report

Merging #3740 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3740   +/-   ##
=======================================
  Coverage   32.67%   32.67%           
=======================================
  Files         114      114           
  Lines       10754    10754           
=======================================
  Hits         3514     3514           
  Misses       7240     7240
Impacted Files Coverage Δ
Source/Charts/Renderers/LineChartRenderer.swift 61.64% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce0d809...44ba57d. Read the comment docs.

@liuxuan30
Copy link
Member

Thanks!

@liuxuan30 liuxuan30 merged commit 9971afc into ChartsOrg:master Nov 15, 2018
@anton-filimonov anton-filimonov deleted the bugfixes/lineChart_lineCapForAll branch December 11, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants